Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable the broken dex login test for now or fix it #2827

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

juliusvonkohout
Copy link
Member

@juliusvonkohout juliusvonkohout commented Aug 1, 2024

Pull Request Template for Kubeflow manifests Issues

✏️ A brief description of the changes

I changed ...

📦 List any dependencies that are required for this change

My PR depends on #

🐛 If this PR is related to an issue, please put the link to the issue here.

The following issues are related, because ...

✅ Contributor checklist


You can join the CNCF Slack and access our meetings at the Kubeflow Community website. Our channel on the CNCF Slack is here #kubeflow-platform.

@tzabbi follow up of #2815

I see

Run pip3 install requests
  pip3 install requests
  ./tests/gh-actions/test_dex_login.py
  shell: /usr/bin/bash -e {0}
Defaulting to user installation because normal site-packages is not writeable
Requirement already satisfied: requests in /usr/lib/python3/dist-packages (2.25.1)
/home/runner/work/_temp/0cb81e68-c08c-4a89-b642-a24c5f9eb9a3.sh: line 2: ./tests/gh-actions/test_dex_login.py: Permission denied
Error: Process completed with exit code 126.

Maybe a chmod +x is needed.

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout juliusvonkohout changed the title disable the broken tex login test for now or fix it disable the broken dex login test for now or fix it Aug 1, 2024
@juliusvonkohout juliusvonkohout self-assigned this Aug 1, 2024
@tzabbi tzabbi mentioned this pull request Aug 2, 2024
@juliusvonkohout
Copy link
Member Author

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hansinikarunarathne
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Aug 2, 2024
@google-oss-prow google-oss-prow bot merged commit 1a3d900 into master Aug 2, 2024
9 of 10 checks passed
pschoen-itsc pushed a commit to pschoen-itsc/kf-manifests that referenced this pull request Sep 3, 2024
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Patrick Schönthaler <patrick.schoenthaler@itsc.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants