Add containerRuntimeExecutor field for other argo executors

[Tomcli]

Description of your changes:
By default, Argo will use the docker containerRuntimeExecutor which it will not work on Kubernetes Cluster that doesn't use docker runtime. Therefore, we want to add the containerRuntimeExecutor field so that users who need different executor runtime can easily change the containerRuntimeExecutor params using kustomize.

Checklist:

• Unit tests have been rebuilt:
  1. cd manifests/tests
  2. make generate
  3. make test

cc: @animeshsingh

---

This change is 

[k8s-ci-robot]

Hi @Tomcli. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Tomcli]

/assign @richardsliu

[richardsliu]

/ok-to-test

[Tomcli]

Thanks @richardsliu, I updated the Argo tests and now the all the presubmit tests are passed.

[swiftdiaries]

@Tomcli
I didn't see this PR and I added this #266 to do the same via an overlay.
I think it'll be better to have an overlay so that a kfctl config can reference the overlay to install. I'm not sure how var substitution works otherwise at runtime from kfctl.
Do you think it makes sense to pull in those changes here? What are your thoughts?

[swiftdiaries]

I used a config like this to init kfctl on the overlay

apiVersion: kfdef.apps.kubeflow.org/v1alpha1
kind: KfDef
metadata:
  name: kubeflow_app
  namespace: kubeflow
spec:
  repos:
  - name: manifests
    root: manifests-master
    uri: https://github.com/swiftdiaries/manifests/archive/containerd-cri-argo.tar.gz
  - name: kubeflow
    root: kubeflow-master
    uri: https://github.com/kubeflow/kubeflow/archive/master.tar.gz
...

And the containerd overlay for the argo application:

...
applications:
  - kustomizeConfig:
      overlays:
      - containerd
      repoRef:
        name: manifests
        path: argo
    name: argo
...

[Tomcli]

Thanks @swiftdiaries, I agree having a containerd overlay is better to apply the changes via kfctl. My intent for this PR is to add the containerRuntimeExecutor variable to the base argo configmap so that other users can build their own custom overlays with the containerRuntimeExecutor variable as well.

[swiftdiaries]

Oh cool, thanks for the clarification ! I can file a PR with the overlay in #266 after this one goes in.

[Tomcli]

cc @animeshsingh

[animeshsingh]

/lgtm

[animeshsingh]

@kkasravi can we get this in? Its gating another PR, and is important for us at IBM to get Argo running with containerd

[animeshsingh]

/assign @kkasravi

[swiftdiaries]

I'll wait for the other reviewers as well but from my side this
/lgtm

[kkasravi]

@Tomcli will you update the config files to include this value
eg kfctl_gcp_iap.yaml

  - kustomizeConfig:
      overlays:
      - istio
      parameters:
      - name: containerRuntimeExecutor
        value: docker
      repoRef:
        name: manifests
        path: argo
    name: argo

[kkasravi]

other than the question about updating the config files which is in a different repository (kubeflow)
/lgtm

[kkasravi]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kkasravi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kkasravi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Tomcli]

Thanks @kkasravi for the review. I submitted a PR to kubeflow to update the corresponding config files.