Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct XGBoostJob CRD group name and add singular name #1313

Merged
merged 2 commits into from
Jun 23, 2020
Merged

Correct XGBoostJob CRD group name and add singular name #1313

merged 2 commits into from
Jun 23, 2020

Conversation

terrytangyuan
Copy link
Member

Which issue is resolved by this Pull Request:
Resolves kubeflow/xgboost-operator#94

Description of your changes:

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate-changed-only
    3. make test

@kubeflow-bot
Copy link
Contributor

This change is Reviewable

@terrytangyuan terrytangyuan changed the title Correct XGBoostJob CRD group name and add singular name [WIP] Correct XGBoostJob CRD group name and add singular name Jun 23, 2020
@terrytangyuan
Fx
6c58510 
Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
@terrytangyuan terrytangyuan changed the title [WIP] Correct XGBoostJob CRD group name and add singular name Correct XGBoostJob CRD group name and add singular name Jun 23, 2020
@terrytangyuan
Copy link
Member Author

/cc @johnugeorge

@Jeffwan
Copy link
Member

Jeffwan commented Jun 23, 2020 •
edited
Loading

@terrytangyuan

Groups has been changed? Is this regenerated?

@Jeffwan
Copy link
Member

Jeffwan commented Jun 23, 2020

/lgtm

@terrytangyuan
Copy link
Member Author

@Jeffwan This is for better consistency among the operators and xgboostjob prefix was unnecessary.

@terrytangyuan
Copy link
Member Author

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@terrytangyuan
Copy link
Member Author

/test kubeflow-manifests-presubmit

@k8s-ci-robot k8s-ci-robot merged commit e15922e into master Jun 23, 2020
@jbottum jbottum mentioned this pull request Nov 19, 2020
Closed
@juliusvonkohout juliusvonkohout deleted the terrytangyuan-patch-1 branch January 12, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hougangliu hougangliu Awaiting requested review from hougangliu

@krishnadurai krishnadurai Awaiting requested review from krishnadurai

@johnugeorge johnugeorge Awaiting requested review from johnugeorge

Assignees

@Jeffwan Jeffwan

Labels
approved cla: yes lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

why the name of xgboost-operator’s group is "xgboostjob.kubeflow.org"
5 participants
@terrytangyuan @kubeflow-bot @Jeffwan @k8s-ci-robot @googlebot