jupyter web app manifest version v3 #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
/assign @kimwnasptd |
|
Test failure looks like a git flake. |
added 2 commits
March 30, 2020 15:54
* Define v3 versions of the manifests that use the patterns as described in http://bit.ly/kf_kustomize_v3 * Define a new base_v3 package * Use a configmap generator to generate a config map containing application specific parameters * Make the parameters available to the command line by setting environment variables to the config map and then referencing them in the command line. Related to kubeflow#774
* Move the jupyter configs back to the base directory so that base is still a valid kustomization package becaue the tests will use the current version of kfctl which doesn't support loader None.
|
build and deploy failed. |
|
@kimwnasptd The tests passed could you please review. |
kimwnasptd
reviewed
Apr 1, 2020
| @@ -18,7 +18,11 @@ spawnerFormDefaults: | |||
| image: | |||
| # The container Image for the user's Jupyter Notebook | |||
| # If readonly, this value must be a member of the list below | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
I think we should go with the HEAD changes :)
Also the generated test data has these lines, I guess you'll have to regenerate the tests?
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define v3 versions of the manifests that use the patterns as described
in http://bit.ly/kf_kustomize_v3
Define a new base_v3 package
Use a configmap generator to generate a config map containing application specific parameters
Make the parameters available to the command line by setting environment variables to
the config map and then referencing them in the command line.
Related to #774