fix vm service account config, doc update #931
Conversation
|
/assign @ankushagarwal |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankushagarwal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Can you sync please? I think VM service account was fixed by #928 |
| ipName: kubeflow-ip | ||
| # Provide the config for the bootstrapper. This should be a string | ||
| # containing the YAML spec for the bootstrapper. | ||
| # | ||
| # You should set the following parameters in bootstrapperConfig. | ||
| # acmeEmail - Set this to your email address; this is used with lets-encrypt. | ||
| # ipName - This is the name of the static ip address reserved in GCP to be used with ingress. | ||
| # keep this in sync with the value of property ipName | ||
| # For each deployment, value of ipName should be same among all configs |
There was a problem hiding this comment.
This comment is confusing. It makes it sound like every deployment should use the same value for ipName which isn't correct because we don't want different Kubeflow deployments to use the same name.
I would say something like
Keep the value of ipName in sync with the value in the bootstrapper config section below.
|
/lgtm |
* fix vm service account config, doc update * rebase, and handle feedback
related to #927.
This bug should be covered by e2e test.
This change is