Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tf notebook image 1.8 version #886

Merged
merged 2 commits into from
May 29, 2018
Merged

Add tf notebook image 1.8 version #886

merged 2 commits into from
May 29, 2018

Conversation

ankushagarwal
Copy link
Contributor

@ankushagarwal ankushagarwal commented May 29, 2018

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

@ankushagarwal: GitHub didn't allow me to request PR reviews from the following users: lluu.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @lluu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ankushagarwal
Copy link
Contributor Author

/cc @lluunn

@k8s-ci-robot k8s-ci-robot requested a review from lluunn May 29, 2018 18:13
@lluunn
Copy link
Contributor

lluunn commented May 29, 2018

Can you also update the supported versions: https://github.com/kubeflow/kubeflow/tree/master/components#tf-notebook

@lluunn
Copy link
Contributor

lluunn commented May 29, 2018

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lluunn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ankushagarwal
Copy link
Contributor Author

/retest

1 similar comment
@ankushagarwal
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit dc41b18 into kubeflow:master May 29, 2018
@ankushagarwal ankushagarwal deleted the tf18-release branch May 29, 2018 23:20
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
* Add tf notebook image 1.8 version

* Add 1.8 to readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants