ksonnet changes to support deploying the v1alpha2 TFJob operator. #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* K8s doesn't support installing multiple versions of a CRD in the same cluster. * So we add an option to choose which version to support. * We don't add an E2E test in this PR because its not straightforward. Currently the E2E test deploys Kubeflow in a different namespace but not a different cluster. This won't allow us to simulatenously test both versions. * So to test multiple versions we will need to spin up a separate GKE cluster. Related to: kubeflow#599
|
/assign @gaocegege |
|
@gaocegege PTAL |
|
/lgtm |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Test failure looks like some random networking issue |
|
/retest |
saffaalvi
pushed a commit
to StatCan/kubeflow
that referenced
this pull request
Feb 11, 2021
…beflow#851) * ksonnet changes to support deploying the v1alpha2 TFJob operator. * K8s doesn't support installing multiple versions of a CRD in the same cluster. * So we add an option to choose which version to support. * We don't add an E2E test in this PR because its not straightforward. Currently the E2E test deploys Kubeflow in a different namespace but not a different cluster. This won't allow us to simulatenously test both versions. * So to test multiple versions we will need to spin up a separate GKE cluster. Related to: kubeflow#599 * Autoformat jsonnet.
yanniszark
pushed a commit
to arrikto/kubeflow
that referenced
this pull request
Feb 15, 2021
* chore: Speedup local build.sh Signed-off-by: Ce Gao <gaoce@caicloud.io> * chore: Update liveness probe Signed-off-by: Ce Gao <gaoce@caicloud.io> * chore: Ignore frontend build Signed-off-by: Ce Gao <gaoce@caicloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
K8s doesn't support installing multiple versions of a CRD in the same cluster.
So we add an option to choose which version to support.
We don't add an E2E test in this PR because its not straightforward.
Currently the E2E test deploys Kubeflow in a different namespace but not
a different cluster. This won't allow us to simulatenously test both
versions.
So to test multiple versions we will need to spin up a separate GKE cluster.
Related to: kubeflow/training-operator#599
This change is