Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a 10 minute timeout for jupyterhub backend in envoy config #486

Merged
merged 3 commits into from
Mar 23, 2018
Merged

Use a 10 minute timeout for jupyterhub backend in envoy config #486

merged 3 commits into from
Mar 23, 2018

Conversation

ankushagarwal
Copy link
Contributor

@ankushagarwal ankushagarwal commented Mar 22, 2018

Downloading images takes some time - envoy simply
shows upstream request timeout which is a bad user
experience

Run jsonnet autoformat

Verified that I no longer see upstream timeout on dev.kubeflow.org when spawning an image

Fixes #261


This change is Reviewable

Downloading images takes some time - envoy simply
shows upstream request timeout which is a bad user
experience

Run jsonnet autoformat

Fixes #261
@ankushagarwal ankushagarwal changed the title Use a 10 minute timeout for jupyterhub backend Use a 10 minute timeout for jupyterhub backend in envoy config Mar 22, 2018
@lluunn
Copy link
Contributor

lluunn commented Mar 23, 2018

/lgtm
Try sync and retest

@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 23, 2018
@lluunn
Copy link
Contributor

lluunn commented Mar 23, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm label Mar 23, 2018
@lluunn
Copy link
Contributor

lluunn commented Mar 23, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lluunn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6e79ad3 into kubeflow:master Mar 23, 2018
@ankushagarwal ankushagarwal deleted the envoy-timeout-large branch March 23, 2018 18:29
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2021
* Init commit

* Half of backend edit

* Backend for v1alpha2 UI is done

* Fix gopkg.toml

* fix gopkg lock

* Almost submit HP job by params done

* Modify gitignore

* Add by parameters for HP and NAS done

* HP and NAS jobs functionality done

* Template is done

* Add new filters in job list
Create a new build with frontend

* Fix newlines

* Review changes

* Add tests for katib-ui

* Delete pkg

* Add pkg

* Fix backend
elenzio9 pushed a commit to arrikto/kubeflow that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants