Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start instructions for creating a release #298

Merged
merged 13 commits into from
Mar 1, 2018
Merged

Start instructions for creating a release #298

merged 13 commits into from
Mar 1, 2018

Conversation

jlewi
Copy link
Contributor

@jlewi jlewi commented Feb 26, 2018 •
edited
Loading

  • Start putting instructions together for how one could release Kubeflow.

  • The instructions are rather adhoc and reflect what one could do today

  • They do not reflect what we think our release process should look like.

  • The current instructions only cover building and releasing TFJob operator and the TFServing images

  • Refactor the TFServing image E2E workflow so we can use it to build release images

    • We want to run a different cluster in a different project for releases and publish to a different GCR
      registry
    • We move the default parameters into the .libsonnet file; The number of parameters was getting
      large so I think it makes sense to pass them as a dictionary and not as a list of arguments
    • Make buildTemplate a local variable so we automatically inherit the values of the parameters
      and don't have to pass a bunch of arguments every time we build it.

  • Update the actual image used by TFSerivng to the newly built image.

  • @willb and some others are putting together a proposal for our release process. Hopefully this PR will help inform that work and help us figure out how to iterate.

  • Related to Create a minimal release process for our ksonnet configs #215

This change is Reviewable

@jlewi
Update.
53d004c
@jlewi
Minor refactor of the workflow component.
72ff0bb 
* Define the default values for the componet in the component library.
* Make buildTemplate a local variable so it inherits context automatically.
@jlewi
Pipeline for building the TF serving image is working.
15197a3
@jlewi
Upgrade the TF serving image.
733c6c5
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

Assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jlewi jlewi changed the title [Wip] Start instructions for creating a release Start instructions for creating a release Feb 28, 2018
@jlewi
Copy link
Contributor Author

jlewi commented Feb 28, 2018

/assign @lluunn

@jlewi
Copy link
Contributor Author

jlewi commented Feb 28, 2018

The workflow for building the TF serving image didn't even seem to run the checkout step.

Lets try rerunning.

/test all

@jlewi
Copy link
Contributor Author

jlewi commented Feb 28, 2018

/test all

@jlewi
Copy link
Contributor Author

jlewi commented Feb 28, 2018

I did

kubectl describe wf $WFNAME

Error is

Status:
  Finished At:  2018-02-28T13:58:22Z
  Message:      invalid spec: template 'e2e' steps[1].create-pr-symlink.template 'create-pr-symlink' undefined
  Phase:        Failed
  Started At:   2018-02-28T13:58:22Z

Looks like maybe a bad merge.

@lluunn
Copy link
Contributor

lluunn commented Mar 1, 2018

Review status: 0 of 10 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.

releasing.md, line 24 at r4 (raw file):

[kubeflow/testing#42](https://github.com/kubeflow/testing/issues/42) will simplify this.

should cd to the workflow dir?

Comments from Reviewable

lluunn
lluunn previously approved these changes Mar 1, 2018
View reviewed changes
Copy link
Contributor

@lluunn lluunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment. Looks good, thanks!

@jlewi
Copy link
Contributor Author

jlewi commented Mar 1, 2018

Review status: 0 of 10 files reviewed at latest revision, 1 unresolved discussion.

releasing.md, line 24 at r4 (raw file):

Previously, lluunn (Lun-Kai Hsu) wrote…

should cd to the workflow dir?

Done.

Comments from Reviewable

@jlewi jlewi merged commit b6bfa74 into kubeflow:master Mar 1, 2018
@jlewi jlewi mentioned this pull request Aug 23, 2019
Closed
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Nov 1, 2019
@avdaredevil @k8s-ci-robot
[CentralDashboard v2] Added env_var for KFAM Server address (kubeflow…
2e42975 
…#298)

* Added an environment variable to central dash to target the correct KFAM target

* Addresed PR comments and updated tests
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2021
@hougangliu @k8s-ci-robot
sync up worker status all the time (kubeflow#299)
b11b81d 
Fixes: kubeflow#298
elenzio9 pushed a commit to arrikto/kubeflow that referenced this pull request Oct 31, 2022
@ellistarn
Created a team for kfserving maintainers (kubeflow#298)
b48c3b1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lluunn lluunn lluunn left review comments

Assignees

@lluunn lluunn

Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlewi @k8s-ci-robot @lluunn