Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes 'ipName and zone are being written to app.yaml even when no platform is specified' #2774

Merged
merged 1 commit into from
Mar 22, 2019

Conversation

kkasravi
Copy link
Contributor

@kkasravi kkasravi commented Mar 21, 2019

fixes #2773


This change is Reviewable

@kkasravi
Copy link
Contributor Author

/assign @lluunn

@kkasravi
Copy link
Contributor Author

/assign @kunmingg

@kkasravi
Copy link
Contributor Author

/assign @gabrielwen

@lluunn
Copy link
Contributor

lluunn commented Mar 22, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lluunn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kkasravi
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 50d08f7 into kubeflow:master Mar 22, 2019
@kkasravi kkasravi deleted the kfctl_ipName_zone_fix branch April 3, 2019 09:34
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ipName and zone are being written to app.yaml even when no platform is specified
6 participants