Polish changes: #2733
Polish changes: #2733
Conversation
- List box text was not visible in blue toolbar mode - Colors adjusted for clearer viewing of namespace selector - Made the message uch easier to read and made it an empty state message
|
Hey @prodonjs can you please test Edit:Missed this, can we tackle this in a later change, I won't be able to work on this any longer, and would like to make it for the |
|
/test kubeflow-presubmit |
|
I didn't see any issues with the deployed image when trying to navigate directly to a deep-link (ie. https://kubeflow.endpoints.prodonjs-kubeflow-dev.cloud.goog/_/notebooks) or to a non-existent route (ie. https://kubeflow.endpoints.prodonjs-kubeflow-dev.cloud.goog/a/bad/route). The presubmit failure is unrelated to the change here as our image is building correctly. /lgtm |
|
/assign @gaocegege Need owners approval for jsonnet file change. |
|
/lgtm |
|
/approve |
|
@avdaredevil |
|
Done, could you please re-lgtm?
…On Tue, Mar 19, 2019, 5:54 PM Kubernetes Prow Robot < ***@***.***> wrote:
New changes are detected. LGTM label has been removed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2733 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFDq6t23Cx9r4qP5h5tVZaySX19n0rChks5vYYaygaJpZM4b7HdG>
.
|
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kunmingg, prodonjs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Polish changes: - List box text was not visible in blue toolbar mode - Colors adjusted for clearer viewing of namespace selector - Made the message uch easier to read and made it an empty state message * Addressed prodonjs' comments * Updated image
* Polish changes: - List box text was not visible in blue toolbar mode - Colors adjusted for clearer viewing of namespace selector - Made the message uch easier to read and made it an empty state message * Addressed prodonjs' comments * Updated image
fixes #2359
Features
/assign @avdaredevil @prodonjs
/review @prodonjs
/priority p0
This change is