Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use iam-policy value for EMAIL if case-sensitive. #1937

Merged
merged 2 commits into from
Nov 15, 2018

Conversation

IMBurbank
Copy link
Contributor

@IMBurbank IMBurbank commented Nov 10, 2018

Fixes #1936

Modify kfctl.createEnv to check for a case-mismatch between the EMAIL value provided by $(gcloud config get-value account) and the value in the iam-policy, and to use the iam-policy value in the case of a mismatch.


This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @IMBurbank. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pdmack
Copy link
Member

pdmack commented Nov 12, 2018

/ok-to-test

@IMBurbank
Copy link
Contributor Author

This PR passed presubmit checks a few days ago, but is beginning to go stale sitting unmerged. The first branch conflict just arose today.

Is there anything else I can do to help this PR through?

@abhi-g
Copy link
Member

abhi-g commented Nov 15, 2018

Sorry about the delay.

/lgtm

@abhi-g
Copy link
Member

abhi-g commented Nov 15, 2018

@IMBurbank Can you please update by merging master.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Nov 15, 2018
@IMBurbank
Copy link
Contributor Author

No problem, and thank you for the response.

Another PR moved the $EMAIL assignment from the createEnv function to parseArgs. I moved this iam-policy check into parseArgs accordingly.

@abhi-g
Copy link
Member

abhi-g commented Nov 15, 2018

/lgtm

@abhi-g
Copy link
Member

abhi-g commented Nov 15, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhi-g

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants