Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base href for correct link in Argo UI #1865

Merged
merged 3 commits into from
Oct 29, 2018

Conversation

andreyvelich
Copy link
Member

@andreyvelich andreyvelich commented Oct 25, 2018

Fixes #1694


This change is Reviewable

@andreyvelich
Copy link
Member Author

/retest

2 similar comments
@andreyvelich
Copy link
Member Author

/retest

@andreyvelich
Copy link
Member Author

/retest

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot
Copy link

CLAs look good, thanks!

@kunmingg
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kunmingg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreyvelich
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 34de207 into kubeflow:master Oct 29, 2018
rogaha pushed a commit to rogaha/kubeflow that referenced this pull request Nov 20, 2018
* Added BaseHref for correct link in Argo UI

* Formatted libsonnet
@Jeffwan
Copy link
Member

Jeffwan commented Feb 6, 2019

@andreyvelich just like to confirm this PR will only work behind Ambassador? If I install argo individually, this will not work.

@andreyvelich
Copy link
Member Author

@Jeffwan Yes, that's true. Right now Argo UI only supports work behind Ambassador.
f you want to use Argo UI individually you have to remove this variable:
https://github.com/kubeflow/kubeflow/blob/master/kubeflow/argo/argo.libsonnet#L161
and remove this annotation from the service:
https://github.com/kubeflow/kubeflow/blob/master/kubeflow/argo/argo.libsonnet#L201

@Jeffwan
Copy link
Member

Jeffwan commented Feb 7, 2019

Cool. Thanks for the confirmation. @andreyvelich

saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
* Added BaseHref for correct link in Argo UI

* Formatted libsonnet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants