Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some latency metrics for GKE & KF deployments #1836

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

abhi-g
Copy link
Member

@abhi-g abhi-g commented Oct 20, 2018

  • Flow start time of request handling through the context
  • create metrics around time to process the requests.

This change is Reviewable

@kunmingg
Copy link
Contributor

Currently stackdriver dashboard force user to choose aligner (between delta or rate) when add a new metrics. This might mess up our histogram metrics.
@jlewi shall we set up standalone dashboard?

@kunmingg
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kunmingg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6f73476 into kubeflow:master Oct 23, 2018
@abhi-g abhi-g deleted the deployment_metrics branch November 13, 2018 21:17
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
surajkota pushed a commit to surajkota/kubeflow that referenced this pull request Jun 13, 2022
Signed-off-by: ted chang <htchang@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants