Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put the full PyTorch prototype in the jsonnet file. #1119

Merged
merged 1 commit into from
Jul 5, 2018

Conversation

jlewi
Copy link
Contributor

@jlewi jlewi commented Jul 3, 2018

  • The current pattern in Kubeflow is to put the complete prototype in
    the jsonnet file. This way the result of ks generate is a .jsonnet
    file containing a full spec. This makes it easy for users to do
    complex modifications starting with the prototype as an example.

  • Configure the prototype to do mnist by default.

Fix #1114


This change is Reviewable

* The current pattern in Kubeflow is to put the complete prototype in
  the jsonnet file. This way the result of ks generate is a .jsonnet
  file containing a full spec. This makes it easy for users to do
  complex modifications starting with the prototype as an example.

* Configure the prototype to do mnist by default.

Fix kubeflow#1114
@jlewi
Copy link
Contributor Author

jlewi commented Jul 3, 2018

/assign @johnugeorge
/assign @ankushagarwal

@johnugeorge
Copy link
Member

/lgtm

@johnugeorge
Copy link
Member

/retest

@ankushagarwal
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankushagarwal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jlewi
Copy link
Contributor Author

jlewi commented Jul 3, 2018

/test all

@ankushagarwal
Copy link
Contributor

Cleaned up some old test gpu pods from the cluster. tests should pass now

@ankushagarwal
Copy link
Contributor

/retest

@jlewi
Copy link
Contributor Author

jlewi commented Jul 5, 2018

/test all

@k8s-ci-robot k8s-ci-robot merged commit 830b5ea into kubeflow:master Jul 5, 2018
jlewi added a commit to jlewi/kubeflow that referenced this pull request Jul 11, 2018
* The current pattern in Kubeflow is to put the complete prototype in
  the jsonnet file. This way the result of ks generate is a .jsonnet
  file containing a full spec. This makes it easy for users to do
  complex modifications starting with the prototype as an example.

* Configure the prototype to do mnist by default.

Fix kubeflow#1114
k8s-ci-robot pushed a commit that referenced this pull request Jul 12, 2018
* The current pattern in Kubeflow is to put the complete prototype in
  the jsonnet file. This way the result of ks generate is a .jsonnet
  file containing a full spec. This makes it easy for users to do
  complex modifications starting with the prototype as an example.

* Configure the prototype to do mnist by default.

Fix #1114
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
* The current pattern in Kubeflow is to put the complete prototype in
  the jsonnet file. This way the result of ks generate is a .jsonnet
  file containing a full spec. This makes it easy for users to do
  complex modifications starting with the prototype as an example.

* Configure the prototype to do mnist by default.

Fix kubeflow#1114
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants