Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetricsReporter fails on nil nodeStatus.Status #334

Closed
rafalbigaj opened this issue Oct 16, 2020 · 4 comments
Closed

MetricsReporter fails on nil nodeStatus.Status #334

rafalbigaj opened this issue Oct 16, 2020 · 4 comments

Comments

@rafalbigaj
Copy link
Contributor

/kind bug

What steps did you take and what happened:
In some failure scenarios the Status in PipelineRunTaskRunStatus can be nil. collectNodeMetricsOrNil is unsafe and crashes.

What did you expect to happen:
This corner case should be ignored.

Additional information:
N/A

Environment:

  • Python Version (use python --version):
  • SDK Version:
  • Tekton Version (use tkn version):
  • Kubernetes Version (use kubectl version):
  • OS (e.g. from /etc/os-release):
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
area/front-end 0.87

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@issue-label-bot
Copy link

Issue Label Bot is not confident enough to auto-label this issue.
See dashboard for more details.

rafalbigaj added a commit to rafalbigaj/kfp-tekton that referenced this issue Oct 16, 2020
rafalbigaj added a commit to rafalbigaj/kfp-tekton that referenced this issue Oct 16, 2020
@Tomcli
Copy link
Member

Tomcli commented Oct 20, 2020

done
/close

@k8s-ci-robot
Copy link

@Tomcli: Closing this issue.

In response to this:

done
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants