Skip to content
This repository has been archived by the owner on Aug 17, 2023. It is now read-only.

Update help doc for --platform=existing_arrikto #32

Merged
merged 1 commit into from
Sep 12, 2019

Conversation

QxiaoQ
Copy link
Contributor

@QxiaoQ QxiaoQ commented Sep 12, 2019

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @QxiaoQ. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jlewi
Copy link
Contributor

jlewi commented Sep 12, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 48f8e14 into kubeflow:master Sep 12, 2019
@QxiaoQ
Copy link
Contributor Author

QxiaoQ commented Sep 18, 2019

Hi @jlewi , Do I need merge this code changes into kubeflow/kubeflow repo?

@QxiaoQ QxiaoQ deleted the update_help_doc branch September 25, 2019 10:05
crobby pushed a commit to crobby/kfctl that referenced this pull request Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants