Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete v1alpha2 api #953

Merged
merged 1 commit into from
Dec 10, 2019
Merged

Conversation

johnugeorge
Copy link
Member

@johnugeorge johnugeorge commented Dec 6, 2019

v1alpha2 is deprecated. Hence, corresponding files are removed from the repository


This change is Reviewable

@johnugeorge
Copy link
Member Author

/cc @richardsliu
/cc @gaocegege
/cc @hougangliu

@gaocegege
Copy link
Member

/lgtm

@johnugeorge
Copy link
Member Author

What can we do about coverage failure? @richardsliu

@gaocegege
Copy link
Member

I think we could lower the limit about test coverage in coveralls. But I have no permission to do it.

@hougangliu
Copy link
Member

/lgtm

@hougangliu
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hougangliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 983583e into kubeflow:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants