Add tfjob and pytorch examples to e2e #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
Suggest rebasing the upstream/master to avoid random copy issues |
johnugeorge
force-pushed
the
customjobs
branch
from
32db265
to
fca591f
Compare
|
/retest |
1 similar comment
|
/retest |
johnugeorge
force-pushed
the
customjobs
branch
from
137d6a2
to
f420637
Compare
|
/lgtm |
hougangliu
reviewed
Sep 29, 2019
| cp -r pkg/apis/manager/v1alpha3/python/* ${GO_DIR}/test/e2e/v1alpha3 | ||
|
|
||
|
|
||
| echo "Deploying tf-operator crds from kubeflow/manifests master" |
There was a problem hiding this comment.
not sure if tf-operator installed here includes commit kubeflow/training-operator@4ee67e2, otherwise a TFJob may succeed but its trial will still keep running
There was a problem hiding this comment.
It is included. kubeflow/manifests#397 is merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TFJob and PytorchJob examples are added to e2e tests
This change is