Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing v1alpha2 grid search suggestion algorithm #622

Merged
merged 3 commits into from
Jun 3, 2019

Conversation

johnugeorge
Copy link
Member

@johnugeorge johnugeorge commented Jun 2, 2019

This tracks the implementation of v1alpha2 grid search suggestion algorithm


This change is Reviewable

@johnugeorge
Copy link
Member Author

/retest

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@johnugeorge
Copy link
Member Author

The number of trials of an experiment is tracked inorder to provide latest suggestions - https://github.com/kubeflow/katib/pull/622/files#diff-f84f68ccb0a20417fb4de6e576218336R83

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege
Copy link
Member

Please rebase

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jun 3, 2019
@andreyvelich
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit cb25807 into kubeflow:master Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants