Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding go tools scripts - part 1 #573

Merged
merged 2 commits into from
May 23, 2019
Merged

Conversation

gyliu513
Copy link
Member

@gyliu513 gyliu513 commented May 22, 2019

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

NONE

/cc @hougangliu @gaocegege @richardsliu

I will try to enable this in CI later.


This change is Reviewable

@gyliu513
Copy link
Member Author

/retest

@hougangliu
Copy link
Member

/test kubeflow-katib-presubmit

@hougangliu
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hougangliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hougangliu
Copy link
Member

/test kubeflow-katib-presubmit

@k8s-ci-robot k8s-ci-robot merged commit 206108a into kubeflow:master May 23, 2019
@gyliu513 gyliu513 deleted the hack branch May 23, 2019 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants