Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid side effect #532

Merged
merged 2 commits into from
May 16, 2019
Merged

fix: Avoid side effect #532

merged 2 commits into from
May 16, 2019

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented May 16, 2019

Signed-off-by: Ce Gao gaoce@caicloud.io

What this PR does / why we need it:

Fix #531

We will meet an error during the creation and retry it again and again. I strongly suggest using state compare pattern instead of current state machine based implementation. But it is another topic.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:



This change is Reviewable

Signed-off-by: Ce Gao <gaoce@caicloud.io>
@gaocegege
Copy link
Member Author

/cc @johnugeorge @richardsliu

@johnugeorge
Copy link
Member

Thanks. This is a required change. I was about to give the comment in #496 before it got merged :)

@gaocegege
Copy link
Member Author

@johnugeorge Yeah my mistake. I did not find this potential problem. And when I am running unit test in #528 I find the logic has bugs.

Signed-off-by: Ce Gao <gaoce@caicloud.io>
Copy link
Member Author

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@johnugeorge PTAL again, thanks

@gaocegege
Copy link
Member Author

/retest

@gaocegege
Copy link
Member Author

@johnugeorge PTAL

@johnugeorge
Copy link
Member

/lgtm

@johnugeorge
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hougangliu
Copy link
Member

/lgtm

@gaocegege
Copy link
Member Author

gaocegege commented May 16, 2019

I am not sure why why bot does not merge the PR automatically.

@johnugeorge
Copy link
Member

Tests failed @gaocegege

@gaocegege
Copy link
Member Author

So the CI will be run again after we approve one PR.

@gaocegege
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 1f90657 into kubeflow:master May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Side effect in Trial controller spawnMetricsCollector
4 participants