Used klog for katib - part 1. #526
Conversation
gyliu513
force-pushed
the
klog
branch
6 times, most recently
from
070ac23
to
3389e58
Compare
|
I will follow up with another PR to update files which using |
|
/retest |
|
@gyliu513 Can you reply to this #506 (comment) ? |
|
/lgtm |
|
This PR mainly replace log in cmd with klog. I am not sure if we should replace zaplogger in controller. Persoanlly LGTM Please rebase |
|
@gaocegege Please see comments here #526 (comment) |
|
Yeah I know you will do it in another PR. But I am not sure if we need it. You need to persuade Johnu 😄 |
|
But personally, I think we could use klog. |
pkg/api/v1alpha2/api.pb.gw.go
Outdated
| "google.golang.org/grpc/status" | ||
| "k8s.io/klog" |
There was a problem hiding this comment.
api.pb.gw.go files are generated based on api.proto, I don't think we should modify the files manually
pkg/api/v1alpha1/api.pb.gw.go
Outdated
| } | ||
| return | ||
| } | ||
| go func() { | ||
| <-ctx.Done() | ||
| if cerr := conn.Close(); cerr != nil { | ||
| grpclog.Printf("Failed to close conn to %s: %v", endpoint, cerr) | ||
| klog.Fatalf("Failed to close conn to %s: %v", endpoint, cerr) |
|
@gyliu513 thanks! |
|
Please rebase the changes |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hougangliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes part of #506
Special notes for your reviewer:
Release note:
This change is