Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Custom Job resources #512

Merged
merged 4 commits into from
May 15, 2019
Merged

Support for Custom Job resources #512

merged 4 commits into from
May 15, 2019

Conversation

johnugeorge
Copy link
Member

@johnugeorge johnugeorge commented May 13, 2019 •
edited by jlewi
Loading

This PR adds support for TF v1beta2 and PyTorch v1beta2 job. Pytorch example is added.
/assign @richardsliu

This change is Reviewable

@johnugeorge johnugeorge mentioned this pull request May 13, 2019
Closed
15 tasks
richardsliu
richardsliu reviewed May 13, 2019
View reviewed changes
pkg/common/v1alpha2/common.go
},
schema.GroupVersionKind{
Group: "kubeflow.org",
Version: "v1beta2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is our versioning story going to be with regards to TFJob and PyTorchJob APIs? Are we always going to be 1 version behind?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, it doesn't matter much to Katib. We can also change to v1 version just before 0.6 release

pkg/controller/v1alpha2/experiment/util/webhook_util.go Outdated Show resolved Hide resolved
pkg/controller/v1alpha2/trial/trial_controller.go Show resolved Hide resolved
@richardsliu
Copy link
Contributor

/retest

1 similar comment
@johnugeorge
Copy link
Member Author

/retest

@johnugeorge
Copy link
Member Author

/retest

1 similar comment
@johnugeorge
Copy link
Member Author

/retest

gaocegege
gaocegege reviewed May 14, 2019
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm with some nits

pkg/controller/v1alpha2/experiment/util/webhook_util.go Outdated Show resolved Hide resolved
@gaocegege gaocegege mentioned this pull request May 14, 2019
Merged
gaocegege
gaocegege reviewed May 14, 2019
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@richardsliu
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardsliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm label May 14, 2019
gaocegege
gaocegege reviewed May 14, 2019
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@johnugeorge
Copy link
Member Author

/retest

4 similar comments
@johnugeorge
Copy link
Member Author

/retest

@richardsliu
Copy link
Contributor

/retest

@richardsliu
Copy link
Contributor

/retest

@richardsliu
Copy link
Contributor

/retest

@gaocegege
Copy link
Member

@johnugeorge Please rebase

@k8s-ci-robot k8s-ci-robot removed the lgtm label May 15, 2019
gaocegege
gaocegege reviewed May 15, 2019
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@richardsliu
Copy link
Contributor

/test all

@richardsliu
Copy link
Contributor

/retest

1 similar comment
@richardsliu
Copy link
Contributor

/retest

@gaocegege
Copy link
Member

It should be blocked by #523

@k8s-ci-robot k8s-ci-robot removed the lgtm label May 15, 2019
gaocegege
gaocegege reviewed May 15, 2019
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit cb559ea into kubeflow:master May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege left review comments

@richardsliu richardsliu richardsliu left review comments

@Akado2009 Akado2009 Awaiting requested review from Akado2009

@garganubhav garganubhav Awaiting requested review from garganubhav

Assignees

@gaocegege gaocegege

@richardsliu richardsliu

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johnugeorge @richardsliu @k8s-ci-robot @gaocegege