Add metrics collector spec to v1alpha2 API #481
Conversation
|
/assign @johnugeorge |
| @@ -50,6 +50,9 @@ type ExperimentSpec struct { | |||
| // TODO - figure out what to do with metric collectors | |||
| MetricsCollectorType string `json:"metricsCollectorSpec,omitempty"` | |||
There was a problem hiding this comment.
I think we can keep it here, since MetricsCollectorSpec is a workaround. In long term, we will use MetricsCollectorType
There was a problem hiding this comment.
If we need to change it in the future, should we deprecate metricsCollectorSpec directly or create a new API version?
There was a problem hiding this comment.
I suggest just deprecate metricsCollectorSpec if there is no big change
|
/lgtm |
|
/retest |
|
Removed metricsCollectorType. If we need to change the metrics collector behavior in the future, we will add this back in a new API version. |
|
/retest |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Part of #442
This change is