Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce some redundant code #296

Merged
merged 1 commit into from
Dec 19, 2018
Merged

reduce some redundant code #296

merged 1 commit into from
Dec 19, 2018

Conversation

hougangliu
Copy link
Member

@hougangliu hougangliu commented Dec 16, 2018 •
edited by jlewi
Loading

This change is Reviewable

@hougangliu
Copy link
Member Author

/assign @richardsliu @YujiOshima

@hougangliu
Copy link
Member Author

/retest

@YujiOshima
Copy link
Contributor

@hougangliu Cool! Thanks! /lgtm

gyliu513
gyliu513 reviewed Dec 18, 2018
View reviewed changes
pkg/controller/studyjob/studyjob_controller.go
@@ -406,6 +408,53 @@ func (r *ReconcileStudyJobController) updateWorker(c katibapi.ManagerClient, ins
return update, nil
}

func(r *ReconcileStudyJobController) getJobWorkerStatus(w *katibv1alpha1.WorkerCondition, ns string) WorkerStatus {
Copy link
Member

@gyliu513 gyliu513 Dec 18, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: s/func(/func (

@hougangliu are you using golint/gofmt to check your code format?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

operator-sdk generates code with "func(" format, all new added methods follows it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see, thanks

@richardsliu
Copy link
Contributor

/lgtm
@hougangliu Thanks for doing this! Please deploy the changes on a cluster and manually verify the changes.

@hougangliu
Copy link
Member Author

@richardsliu Sure, verified already

@richardsliu
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardsliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 07e0fd2 into kubeflow:master Dec 19, 2018
@hougangliu hougangliu deleted the cleanWorkerjobCode branch December 20, 2018 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gyliu513 gyliu513 gyliu513 left review comments

@libbyandhelen libbyandhelen Awaiting requested review from libbyandhelen

@texasmichelle texasmichelle Awaiting requested review from texasmichelle

Assignees

@YujiOshima YujiOshima

@richardsliu richardsliu

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hougangliu @YujiOshima @richardsliu @k8s-ci-robot @gyliu513