Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update README #281

Merged
merged 1 commit into from
Dec 11, 2018
Merged

update README #281

merged 1 commit into from
Dec 11, 2018

Conversation

hougangliu
Copy link
Member

@hougangliu hougangliu commented Dec 10, 2018

This change is Reviewable

@hougangliu
Copy link
Member Author

/assign @richardsliu

README.md Outdated
- optimizationtype: Optimization direction of the objective value. 1=maximize 2=minimize
- suggestalgorithm: [random, grid, hyperband] now
- objectivevaluename: Name of the objective value. Your evaluated software should print log `{objectivevaluename}={objective value}` in std-io.
- optimizationtype: Optimization direction of the objective value. [minimize, maximize] now.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated to [minimize, maximize] are available now

@richardsliu
Copy link
Contributor

Do you want to also update the README for TFJobs? It is supported now.

@hougangliu
Copy link
Member Author

OK, I will try tfjob right now and update README after then.

@hougangliu
Copy link
Member Author

It seems StudyConfig section is out of date( I think CRD StudyJob had replaced it now). I think we should remove the section and detail how to define StudyJob in another user doc.

@richardsliu
Copy link
Contributor

@hougangliu Sounds good, please remove it.

@hougangliu
Copy link
Member Author

@richardsliu Thanks! Done!

@richardsliu
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardsliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 86cddd3 into kubeflow:master Dec 11, 2018
@hougangliu hougangliu deleted the update-readme branch December 17, 2018 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants