Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor studyjobcontroller #254

Merged
merged 5 commits into from
Nov 20, 2018
Merged

Refactor studyjobcontroller #254

merged 5 commits into from
Nov 20, 2018

Conversation

richardsliu
Copy link
Contributor

@richardsliu richardsliu commented Nov 20, 2018 •
edited by jlewi
Loading

Refactor studyjobcontroller into 4 files:

  • studyjobcontroller.go: main logic
  • katib_api_util: wrappers for calling katib APIs
  • model_db_util: wrapper for modelDB operations
  • manifest_parser: parsers worker manifests

This change is Reviewable

@richardsliu
Copy link
Contributor Author

/assign @YujiOshima

@johnugeorge
Copy link
Member

How about renaming the folder 'studyjobcontroller' ->'studyjob'? As it is already in controller folder, it looks redundant.

YujiOshima
YujiOshima reviewed Nov 20, 2018
View reviewed changes
pkg/controller/studyjobcontroller/model_db_util.go Outdated
@@ -0,0 +1,94 @@
// Copyright 2018 The Kubeflow Authors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not only for ModelDB.
It will be an interface for the model management systems including ModelDB.
So I want to rename it to model_util.go.

@YujiOshima
Copy link
Contributor

@richardsliu Thank you! Generally LGTM. One comment, please check.
And I agree with @johnugeorge . If rename the folder, it's better to rename package of studyjobcontroller to studyjob.
@richardsliu WDYT?

@johnugeorge
Copy link
Member

/lgtm

@richardsliu
Copy link
Contributor Author

@YujiOshima @johnugeorge Done.

@YujiOshima
Copy link
Contributor

@richardsliu Thank you!
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YujiOshima

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e5e2dcd into kubeflow:master Nov 20, 2018
@richardsliu richardsliu deleted the refactor_controller branch May 8, 2019 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YujiOshima YujiOshima YujiOshima left review comments

@ddysher ddysher Awaiting requested review from ddysher

@texasmichelle texasmichelle Awaiting requested review from texasmichelle

Assignees

@johnugeorge johnugeorge

@YujiOshima YujiOshima

Labels
approved lgtm size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@richardsliu @johnugeorge @YujiOshima @k8s-ci-robot