Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Scikit-Learn Version for Skopt Tests #2336

Merged
merged 1 commit into from
May 29, 2024

Conversation

andreyvelich
Copy link
Member

This should fix our CI for skopt suggestion. We are getting this error in the most recent sckit-learn version:

E   ImportError: cannot import name 'check_pandas_support' from 'sklearn.utils' 
(/Users/avelichk/miniconda3/envs/katib-ci/lib/python3.9/site-packages/sklearn/utils/__init__.py)

Eventually, we should deprecate skopt in favour of GPSampler from Optuna: #2280 (comment) for bayesian optimization in Katib.

cc @contramundum53

/assign @kubeflow/wg-training-leads

Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm

@andreyvelich
Copy link
Member Author

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit a1046db into kubeflow:master May 29, 2024
60 checks passed
@andreyvelich andreyvelich deleted the fix-ci-skopt branch May 29, 2024 00:15
andreyvelich added a commit to andreyvelich/katib that referenced this pull request Jun 10, 2024
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
johnugeorge pushed a commit that referenced this pull request Jun 11, 2024
shashank-iitbhu pushed a commit to shashank-iitbhu/katib that referenced this pull request Jun 19, 2024
Signed-off-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants