Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Stale Action Every 5th Hour #2221

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

andreyvelich
Copy link
Member

Currently, Stale Actions process a few issues/PRs per run every day: https://github.com/kubeflow/katib/actions/runs/5941243672

I changed Stale action to run every 5 hour to process more stale issues/PRs.
That should help us to track more issues and don't hit GitHub REST API limits: https://docs.github.com/en/rest/overview/resources-in-the-rest-api?apiVersion=2022-11-28#rate-limits-for-requests-from-github-actions
Also, I changed operations-per-run to 60.

WDYT @tenzen-y @johnugeorge ?

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -20,6 +20,7 @@ jobs:
- uses: actions/stale@v5
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
operations-per-run: 60
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep using the default value (30) here? My concern is that by increasing this value to 60, other jobs failed to run due to the GitHub API limit.

WDYT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, sounds good. Let's keep the default value for now since we are going to run this action every 5th hour.

Copy link
Member

@tenzen-y tenzen-y Aug 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If any problem occurs, re-considering the parameters would be great :)

@tenzen-y
Copy link
Member

Thanks!
/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Aug 23, 2023
@google-oss-prow google-oss-prow bot merged commit 373f6e6 into kubeflow:master Aug 23, 2023
58 checks passed
@andreyvelich andreyvelich deleted the change-schedule-stale branch August 23, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants