Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Enable resource specification for trial containers #2192

Merged
merged 1 commit into from
Aug 5, 2023

Conversation

droctothorpe
Copy link
Contributor

@droctothorpe droctothorpe commented Aug 2, 2023

What this PR does / why we need it:
Currently, the only way to specify cpu and memory limits and requests for trial containers is by submitting a manifest directly. For example: here.

This PR adds resource specification capabilities to the SDK's tune method to achieve parity with direct manifest submission. resources_per_trial defaults to None, which aligns with what kubernetes.client.V1ResourceRequirements defaults to, so when resources_per_trial is not specified, the behavior is unmodified.

Which issue(s) this PR fixes
Fixes #2191

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this great improvement @droctothorpe!

sdk/python/v1beta1/kubeflow/katib/api/katib_client.py Outdated Show resolved Hide resolved
Co-authored-by: shipengcheng1230 <shipengcheng1230@gmail.com>
Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this great feature @droctothorpe!
/lgtm
/assign @tenzen-y @johnugeorge @gaocegege

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@droctothorpe Thanks!
/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droctothorpe, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 923d0fc into kubeflow:master Aug 5, 2023
58 checks passed
@droctothorpe droctothorpe deleted the resources branch August 6, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable resource specification for trial containers in the tune method of the SDK
5 participants