Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Show message in case of uncompleted trial instead of the graph #2063

Conversation

elenzio9
Copy link
Contributor

In this PR, we implement the following:

  • Show message in case of uncompleted trial instead of the graph.
    image
  • Add some text below the spinner in order to inform users why we're spinning about.
    image

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI, @elenzio9!
Thanks for this improvement!

Some CI jobs seem to fail, but the errors will be fixed once #2064 is merged with the master branch.

@kimwnasptd Could you help review this PR?

/assign @kimwnasptd

@elenzio9
Copy link
Contributor Author

HI, @elenzio9! Thanks for this improvement!

Some CI jobs seem to fail, but the errors will be fixed once #2064 is merged with the master branch.

Your welcome! OK, thanks!

@tenzen-y
Copy link
Member

@elenzio9 Can you rebase this since we have merged #2064 into the master branch?

Signed-off-by: Elena Zioga <elena@arrikto.com>
Signed-off-by: Elena Zioga <elena@arrikto.com>
@elenzio9 elenzio9 force-pushed the feature-elena-kwa-not-showing-trial-graph branch from a8875da to 207d9fa Compare December 15, 2022 09:34
@elenzio9
Copy link
Contributor Author

@elenzio9 Can you rebase this since we have merged #2064 into the master branch?

I just force pushed!

@orfeas-k
Copy link
Contributor

The code looks good. I also tested the PR's image and everything works as expected. Thank you @elenzio9 for this improvement!
cc @kimwnasptd
/lgtm

@kimwnasptd
Copy link
Member

Thank you for taking a look @orfeas-k!

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elenzio9, kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 2a6497f into kubeflow:master Jan 16, 2023
@kimwnasptd kimwnasptd deleted the feature-elena-kwa-not-showing-trial-graph branch January 16, 2023 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants