Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Add source maps in the browser #2043

Merged

Conversation

elenzio9
Copy link
Contributor

In this PR, we enable source maps for all scripts, styles and node modules in both development and production in KWA.

Related PR: kubeflow/kubeflow#6787

* Enable source maps in both development and production.

Signed-off-by: Elena Zioga <elena@arrikto.com>
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kimwnasptd Can you help us to review this PR?

/assign @kimwnasptd

@orfeas-k
Copy link
Contributor

orfeas-k commented Jan 5, 2023

Tested the PR and the source maps work as expected, thank you @elenzio9!
cc @kimwnasptd
/lgtm

@kimwnasptd
Copy link
Member

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elenzio9, kimwnasptd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 1a128ae into kubeflow:master Jan 16, 2023
@kimwnasptd kimwnasptd deleted the feature-elena-kwa-source-maps branch January 16, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants