Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kwa(build): Introduce COMMIT file for building KWA #2014

Conversation

orfeas-k
Copy link
Contributor

This PR introduces a new COMMIT file that contains the commit where Katib needs to checkout inside Kubeflow's common code in order to be built. The file was integrated in the following places as well:

  • Dockerfile
  • GH actions
  • README.md

This way, a developer may only update one file each time we need to checkout to a newer commit.

Introduce COMMIT file that contains the commit where Katib needs to
checkout inside Kubeflow's common code in order to be built. This file
was integrated in the following places as well, thus a developer may
only update one file each time we need to checkout to a newer commit.
 - Dockerfile
 - GH actions
 - README.md

Signed-off-by: Orfeas Kourkakis <orfeas@arrikto.com>
@kimwnasptd
Copy link
Member

Thanks @orfeas-k! This will make it easier to update the common code in one place without having to touch many different parts.

Plus, without this we would need to update the GH Actions every time which means triggering everything. Now we'll only need to update the frontend/COMMIT file.

From my side
/lgtm

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 73.419% when pulling ec45caf on arrikto:feature-orfeas-k-introduce-commit-file into cdd0b90 on kubeflow:master.

@johnugeorge
Copy link
Member

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, orfeas-k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 24c970b into kubeflow:master Nov 16, 2022
@kimwnasptd kimwnasptd deleted the feature-orfeas-k-introduce-commit-file branch November 17, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants