Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for arm64 in enas-cnn-cifar10 image #1944

Merged

Conversation

tenzen-y
Copy link
Member

Signed-off-by: tenzen-y yuki.iwai.tz@gmail.com

What this PR does / why we need it:
I modified Dockerfile for enas-cnn-cifar10 image to support arm64 and I tested operations in the below commands:

$ # For arm64
$ docker run -it --platform linux/arm64 ytenzen/multiplatform-enas-cnn-cifar10-gpu:latest  --num_gpus=0 --num_epochs=1 --architecture="[[49]]" --nn_config="{'num_layers': 1, 'input_sizes': [32, 32, 3], 'output_sizes': [10], 'embedding': {'49': {'opt_id': 49, 'opt_type': 'separable_convolution', 'opt_params': {'filter_size': '3', 'num_filter': '128', 'stride': '2', 'depth_multiplier': '2'}}}}"
$ # For amd64
$ docker run -it --platform linux/amd64 ytenzen/multiplatform-enas-cnn-cifar10-gpu:latest  --num_gpus=0 --num_epochs=1 --architecture="[[49]]" --nn_config="{'num_layers': 1, 'input_sizes': [32, 32, 3], 'output_sizes': [10], 'embedding': {'49': {'opt_id': 49, 'opt_type': 'separable_convolution', 'opt_params': {'filter_size': '3', 'num_filter': '128', 'stride': '2', 'depth_multiplier': '2'}}}}"

Also, I fixed a bug in TARGETARCH for enas-cnn-cifar10 and tf-mnist-with-summaries images.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part-of #1900

Checklist:

  • Docs included if any changes are user facing

@coveralls
Copy link

coveralls commented Aug 30, 2022

Coverage Status

Coverage decreased (-0.1%) to 73.431% when pulling 7d4f487 on tenzen-y:support-for-arm64-in-enas-image into 6870587 on kubeflow:master.

Signed-off-by: tenzen-y <yuki.iwai.tz@gmail.com>
@tenzen-y tenzen-y force-pushed the support-for-arm64-in-enas-image branch from ff6f485 to 7d4f487 Compare August 30, 2022 16:47
@anencore94
Copy link
Member

/lgtm 👍

@johnugeorge
Copy link
Member

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tenzen-y
Copy link
Member Author

@johnugeorge Can you also add /lgtm to this PR?

@johnugeorge
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Aug 31, 2022
@google-oss-prow google-oss-prow bot merged commit daf5b9b into kubeflow:master Aug 31, 2022
@tenzen-y tenzen-y deleted the support-for-arm64-in-enas-image branch August 31, 2022 17:39
@tenzen-y
Copy link
Member Author

Thanks! @johnugeorge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants