Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix push script to include new images #1911

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Fix push script to include new images #1911

merged 1 commit into from
Jun 30, 2022

Conversation

johnugeorge
Copy link
Member

Push script was not updated with new image names

@johnugeorge johnugeorge mentioned this pull request Jun 30, 2022
Merged
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 72.857% when pulling bff6538 on johnugeorge:pushfix into 7847094 on kubeflow:master.

tenzen-y
tenzen-y approved these changes Jun 30, 2022
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @johnugeorge
/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jun 30, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 8f182c2 into kubeflow:master Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y approved these changes

@anencore94 anencore94 Awaiting requested review from anencore94

@sperlingxx sperlingxx Awaiting requested review from sperlingxx

Assignees

@tenzen-y tenzen-y

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnugeorge @coveralls @tenzen-y