Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the FPGA examples documentation #1841

Merged
merged 2 commits into from
Apr 6, 2022
Merged

Fix the FPGA examples documentation #1841

merged 2 commits into from
Apr 6, 2022

Conversation

eliaskoromilas
Copy link
Member

What this PR does:

  • Set kube-system as the suggested (InAccel FPGA Operator) namespace
  • Replace broken link

The new link points to a MicroK8s + InAccel + Katib tutorial.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eliaskoromilas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

coveralls commented Mar 31, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 73.754% when pulling 309c208 on eliaskoromilas:fpga-examples into d443ed3 on kubeflow:master.

tenzen-y
tenzen-y reviewed Mar 31, 2022
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this documentation @eliaskoromilas!

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Mar 31, 2022
@johnugeorge
Copy link
Member

Related: #1842

@johnugeorge
Copy link
Member

can you rebase?

@eliaskoromilas
Set kube-system as the suggested namespace
0f8a6ac 
Signed-off-by: Elias Koromilas <elias.koromilas@gmail.com>
@eliaskoromilas
Replace broken link
309c208 
Signed-off-by: Elias Koromilas <elias.koromilas@gmail.com>
@google-oss-prow google-oss-prow bot removed the lgtm label Apr 5, 2022
@eliaskoromilas
Copy link
Member Author

rebase

@gaocegege
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Apr 6, 2022
@google-oss-prow google-oss-prow bot merged commit 2985423 into kubeflow:master Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@anencore94 anencore94 Awaiting requested review from anencore94

Assignees

@gaocegege gaocegege

@tenzen-y tenzen-y

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eliaskoromilas @coveralls @johnugeorge @gaocegege @tenzen-y