Fix default label for Training Operators #1808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-oss-prow
bot
requested review from
hougangliu,
johnugeorge and
sperlingxx
|
cc @kubeflow/wg-training-leads FYI |
tenzen-y
reviewed
Feb 14, 2022
There was a problem hiding this comment.
Nice catch @andreyvelich!
Should we modify the description in the following docs?
In **Pod Level Injecting**,
1. Job operators (_e.x. TFjob/PyTorchjob_) tag the `job-role: master` ([#1064](https://github.com/kubeflow/tf-operator/pull/1064)) label on the master pod.For example, for TFJob:
. . .
PrimaryPodLabel:
"job-role": "master"
. . .
Sure, let's change the proposals also. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/lgtm |
google-oss-prow bot
pushed a commit
that referenced
this pull request
Feb 15, 2022
…ors on release-0.13 (#1813) * Fix default label for Training Operators * Fix version comment * Change the docs * Change git command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the default label for Kubeflow Training Operators.
After this we should be able to run E2E Kubeflow example: https://github.com/kubeflow/katib/blob/master/examples/v1beta1/kubeflow-pipelines/kubeflow-e2e-mnist.ipynb.
We have to cherry pick this change on
release-0.13branch and make the new RC./assign @kimwnasptd @tenzen-y @gaocegege @johnugeorge