Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support JSON format logs in file-metrics-collector #1765

Merged
merged 15 commits into from
Apr 5, 2022
Merged

Support JSON format logs in file-metrics-collector #1765

merged 15 commits into from
Apr 5, 2022

Commits on Apr 5, 2022

  1. support JSON format logs in file-metrics-collector

    @tenzen-y
    tenzen-y committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    c82fdf5 View commit details
    Browse the repository at this point in the history

  2. review: convert fileFormat to type FileSystemFileFormat

    @tenzen-y
    tenzen-y committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    572f071 View commit details
    Browse the repository at this point in the history

  3. Update cmd/metricscollector/v1beta1/file-metricscollector/main.go 

    Co-authored-by: Andrey Velichkevich <andrey.velichkevich@gmail.com>
    @tenzen-y @andreyvelich
    tenzen-y and andreyvelich committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    0265372 View commit details
    Browse the repository at this point in the history

  4. review: remove func (f FileSystemFileFormat) String()

    @tenzen-y
    tenzen-y committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    c38dd5a View commit details
    Browse the repository at this point in the history

  5. review: get metricRegList only when the format is TEXT

    @tenzen-y
    tenzen-y committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    703bed8 View commit details
    Browse the repository at this point in the history

  6. review: change var name in a script for e2e

    @tenzen-y
    tenzen-y committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    d95f2a0 View commit details
    Browse the repository at this point in the history

  7. review: explict specify the cloudml-hypyertune in the Dockerfile

    @tenzen-y
    tenzen-y committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    68ffbcc View commit details
    Browse the repository at this point in the history

  8. review: use reflect.DeepEqual instead of go-cmp.Diff

    @tenzen-y
    tenzen-y committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    2c8aaa1 View commit details
    Browse the repository at this point in the history

  9. review: stop using 'JSON' directly in error statements

    @tenzen-y
    tenzen-y committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    8fb51d4 View commit details
    Browse the repository at this point in the history

  10. review: install specific version cloudml-hypertune

    @tenzen-y
    tenzen-y committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    6930468 View commit details
    Browse the repository at this point in the history

  11. review: get objType in the updateStopRules function

    @tenzen-y
    tenzen-y committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    774dd4b View commit details
    Browse the repository at this point in the history

  12. review: save optimalObjValue across multiple stopRules

    @tenzen-y
    tenzen-y committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    051952a View commit details
    Browse the repository at this point in the history

  13. review: add warning messages to parseTimestamp func

    @tenzen-y
    tenzen-y committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    35cfcff View commit details
    Browse the repository at this point in the history

  14. review: generate test files with go test command

    @tenzen-y
    tenzen-y committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    26f04ef View commit details
    Browse the repository at this point in the history

  15. review: change api for new feature

    @tenzen-y
    tenzen-y committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    cb456dd View commit details
    Browse the repository at this point in the history