Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement some unit tests for the katibconfig package #1690

Merged
merged 9 commits into from
Oct 8, 2021
Merged

Implement some unit tests for the katibconfig package #1690

merged 9 commits into from
Oct 8, 2021

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Oct 1, 2021 •
edited
Loading

What this PR does / why we need it:

Implement some unit tests for the following functions in the katibconfig package since it has not been sufficiently tested.
In addition, fix some mistyped comments and envtest for suggestion-controller.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
Ref #1680 (comment)

/assign
/cc @andreyvelich

@tenzen-y tenzen-y changed the title Implement some unit tests for the katib-config package Implement some unit tests for the katibconfig package Oct 1, 2021
andreyvelich
andreyvelich reviewed Oct 2, 2021
View reviewed changes
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this great contribution and code cleaning @tenzen-y!
I left few comments.

/assign @gaocegege @johnugeorge

pkg/util/v1beta1/katibconfig/config_test.go Show resolved Hide resolved
pkg/util/v1beta1/katibconfig/config_test.go Outdated Show resolved Hide resolved
pkg/util/v1beta1/katibconfig/config_test.go Outdated Show resolved Hide resolved
@tenzen-y tenzen-y force-pushed the implement-unit-test-for-katibconfig branch from 7e9739d to 6397388 Compare October 6, 2021 13:31
@tenzen-y
Copy link
Member Author

tenzen-y commented Oct 6, 2021

rebase

@tenzen-y
Copy link
Member Author

tenzen-y commented Oct 6, 2021

Sorry for the delay in fixing this. @andreyvelich
Could you check this PR since I have reflected on your all review comments?

@andreyvelich
Copy link
Member

Thank you for changing this @tenzen-y!
/lgtm
/assign @gaocegege @johnugeorge

@google-cla
Copy link

google-cla bot commented Oct 7, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@tenzen-y
Copy link
Member Author

tenzen-y commented Oct 7, 2021

@gaocegege
Could you comment with @googlebot I fixed it.?

@tenzen-y
Copy link
Member Author

tenzen-y commented Oct 7, 2021

@googlebot I fixed it.

@google-cla
Copy link

google-cla bot commented Oct 7, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Oct 7, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@gaocegege
Copy link
Member

@googlebot I fixed it.

@google-cla
Copy link

google-cla bot commented Oct 8, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@gaocegege

This comment has been minimized.

Sign in to view
@andreyvelich
Copy link
Member

Please rebase the upstream master.

BTW, we cannot use suggestion commit in Kubeflow community, since Google CLA will check if the PR contains only commits from one author. You should reset the last one and commit with your own git user.

@gaocegege It works in the previous PRs: #1691.
Can you try to comment: @googlebot I consent. ?

@google-cla
Copy link

google-cla bot commented Oct 8, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@gaocegege
Copy link
Member

@googlebot I consent.

@google-cla
Copy link

google-cla bot commented Oct 8, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@andreyvelich
Copy link
Member

@gaocegege It also might be because you were using ce.gao@outlook.com to make this comment.
See this commit: 9594b75
Did you sign the CLA on that account ?

@gaocegege
Copy link
Member

@googlebot I consent.

@gaocegege
Copy link
Member

@andreyvelich Thanks! It works.

@tenzen-y tenzen-y force-pushed the implement-unit-test-for-katibconfig branch from 9594b75 to 4c04435 Compare October 8, 2021 02:33
@tenzen-y
Copy link
Member Author

tenzen-y commented Oct 8, 2021

Resolve conflicts

@tenzen-y
Copy link
Member Author

tenzen-y commented Oct 8, 2021

This PR is ready.

gaocegege
gaocegege reviewed Oct 8, 2021
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for your contribution! 🎉 👍

@andreyvelich
Copy link
Member

Thank you for doing this @tenzen-y!
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreyvelich
Copy link
Member

/lgtm

@google-oss-robot google-oss-robot merged commit 6de09d7 into kubeflow:master Oct 8, 2021
@tenzen-y tenzen-y deleted the implement-unit-test-for-katibconfig branch October 8, 2021 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege left review comments

@andreyvelich andreyvelich Awaiting requested review from andreyvelich

Assignees

@johnugeorge johnugeorge

@gaocegege gaocegege

@andreyvelich andreyvelich

@tenzen-y tenzen-y

Labels
approved lgtm size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tenzen-y @andreyvelich @gaocegege @google-oss-robot @johnugeorge