Update Go version to 1.17 #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-robot
requested review from
hougangliu,
johnugeorge and
sperlingxx
tenzen-y
requested changes
Sep 28, 2021
hack/tools.go
Outdated
| @@ -0,0 +1,30 @@ | |||
| // +build tools | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Sure, it makes sense.
I also updated go get to go install for golangci-lint since we are using Go 1.16+ (ref: https://golangci-lint.run/usage/install/#install-from-source).
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check discussion: #1678 (comment).
I updated Go version to 1.17.
Go 1.17 explicitly adds indirect dependencies (See release notes: https://golang.org/doc/go1.17#go-command).
Also, I fixed problem with
code-generatorby creatingtools.gofile with required imports and moving it torequire.I believe, other projects follow the similar way.
/assign @tenzen-y @gaocegege @johnugeorge @anencore94