Move the GKEDemo into kubeflow/examples #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The GKEDemo is using the GitHub summarization example; I think we should put all of the code for that demo kubeflow/examples (see kubeflow/examples#161) * The main code is the Katib HP controller git-issue-summarize-demo.go * We don't need the manifests for deploying katib because we can deploy Katib using the Kubeflow ksonnet package. * The code in docker-image duplicates the code in kubeflow/examples so we shouldn't need it. Related to: kubeflow#116
|
/assign @gaocegege |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: YujiOshima The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GKEDemo is using the GitHub summarization example; I think we should
put all of the code for that demo kubeflow/examples
(see Create a deployment to run the HP/Katib controller for the GitHub issue example examples#161)
The main code is the Katib HP controller git-issue-summarize-demo.go
We don't need the manifests for deploying katib because we can deploy
Katib using the Kubeflow ksonnet package.
The code in docker-image duplicates the code in kubeflow/examples so we
shouldn't need it.
Related to: #116