UI: Remove antd package #1117
Merged
UI: Remove antd package #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change TabPanel for creating Experiment Move TabPanel to Common components
|
This change is |
gaocegege
reviewed
Apr 2, 2020
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/lgtm |
sperlingxx
pushed a commit
to sperlingxx/katib
that referenced
this pull request
Jul 9, 2020
* Remove antd package Change TabPanel for creating Experiment Move TabPanel to Common components * Remove antd from package.json * Modify Katib Link and Main Page * Change Trial and Jobs monitor * Fix links, margin in Trial view * Increase margin for Trial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed
antdpackage from Katib UI.We use
antdto create tabs (YAML File, Parameters) in Experiment create page.Because of this package, create Experiment by parameters doesn't work correct in Safari browser. Thanks @johnugeorge for found it.
I removed this package and created new component for NAS and HP (TabPanel) using Material UI. It also works faster than
antd.I tested new UI in Chrome, Safari, Firefox, everything is working.
Also, some html components were using styles from
antd/dist/antd.css.Since I delete it, I added all styles to appropriate Katib UI components to follow the same design as we have now.
/assign @johnugeorge @gaocegege