Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Documentation] Add information about Katib controller flags #1239

Closed
andreyvelich opened this issue Jun 25, 2020 · 8 comments · Fixed by #1449
Closed

[Documentation] Add information about Katib controller flags #1239

andreyvelich opened this issue Jun 25, 2020 · 8 comments · Fixed by #1449
Labels
area/docs area/katib good first issue Good for newcomers help wanted Extra attention is needed kind/feature lifecycle/frozen

Comments

@andreyvelich
Copy link
Member

/kind feature

As we can see here: https://github.com/kubeflow/katib/blob/master/cmd/katib-controller/v1beta1/main.go#L48-L55, user can specify flags for the Katib Controller.
I think it would be good if we can document this information in Kubeflow website or in developer guide.

/good-first-issue
/area docs
@k8s-ci-robot
Copy link

@andreyvelich:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/kind feature

As we can see here: https://github.com/kubeflow/katib/blob/master/cmd/katib-controller/v1beta1/main.go#L48-L55, user can specify flags for the Katib Controller.
I think it would be good if we can document this information in Kubeflow website or in developer guide.

/good-first-issue
/area docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/feature area/docs good first issue Good for newcomers help wanted Extra attention is needed labels Jun 25, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
area/katib 0.82

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@issue-label-bot
Copy link

Issue Label Bot is not confident enough to auto-label this issue.
See dashboard for more details.

1 similar comment
@issue-label-bot
Copy link

Issue Label Bot is not confident enough to auto-label this issue.
See dashboard for more details.

@stale
Copy link

stale bot commented Nov 24, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@andreyvelich
Copy link
Member Author

/lifecycle frozen

@annajung annajung mentioned this issue Feb 25, 2021
Merged
@annajung
Copy link
Member

Opened up a PR to address the documentation. Please take a look when you can @andreyvelich

@andreyvelich
Copy link
Member Author

Thank you so much for doing this @annajung!
I will take a look soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/docs area/katib good first issue Good for newcomers help wanted Extra attention is needed kind/feature lifecycle/frozen
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add katib controller flags to developers guide annajung/katib
3 participants
@k8s-ci-robot @annajung @andreyvelich