-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete Suggestion deployment after Experiment is finished #1061
Comments
Issue-Label Bot is automatically applying the labels:
Please mark this comment with 👍 or 👎 to give our bot feedback! |
Really useful feature! |
/priority p0 |
Close this issue, since PR is merged. |
@andreyvelich: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/kind feature
Right now, when user creates Experiment, Suggestion deployment is always running. Even after Experiment is finished.
We should add Flag in the API if user wants to delete Suggestion deployment after Experiment is finished.
For example we can use
ResumeExperiment
flag here: https://github.com/kubeflow/katib/blob/master/pkg/apis/controller/experiments/v1alpha3/experiment_types.go#L54.ResumeExperiment: False
if user wants to delete Suggestion after experiment is finished.ResumeExperiment: True
if user doesn't want to delete Suggestion after experiment is finished./cc @johnugeorge @richardsliu @hougangliu @gaocegege
The text was updated successfully, but these errors were encountered: