Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Suggestion deployment after Experiment is finished #1061

Closed
andreyvelich opened this issue Feb 19, 2020 · 5 comments
Closed

Delete Suggestion deployment after Experiment is finished #1061

andreyvelich opened this issue Feb 19, 2020 · 5 comments

Comments

@andreyvelich
Copy link
Member

/kind feature

Right now, when user creates Experiment, Suggestion deployment is always running. Even after Experiment is finished.
We should add Flag in the API if user wants to delete Suggestion deployment after Experiment is finished.

For example we can use ResumeExperiment flag here: https://github.com/kubeflow/katib/blob/master/pkg/apis/controller/experiments/v1alpha3/experiment_types.go#L54.

  1. ResumeExperiment: False if user wants to delete Suggestion after experiment is finished.
  2. ResumeExperiment: True if user doesn't want to delete Suggestion after experiment is finished.

/cc @johnugeorge @richardsliu @hougangliu @gaocegege

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
feature 0.89

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@sperlingxx
Copy link
Member

Really useful feature!

@gaocegege
Copy link
Member

/priority p0

@andreyvelich
Copy link
Member Author

Close this issue, since PR is merged.
/close

@k8s-ci-robot
Copy link

@andreyvelich: Closing this issue.

In response to this:

Close this issue, since PR is merged.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants