fix: Fix test cases

Signed-off-by: Ce Gao <gaoce@caicloud.io>
kubeflow · Jun 12, 2019 · eca734a · eca734a
1 parent 603d1bb
commit eca734a
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 36 deletions.
diff --git a/pkg/controller/v1alpha2/experiment/experiment_controller_test.go b/pkg/controller/v1alpha2/experiment/experiment_controller_test.go
@@ -83,12 +83,6 @@ func TestCreateExperiment(t *testing.T) {
 
 	stopMgr, mgrStopped := StartTestManager(mgr, g)
 
-	stopCh := make(chan struct{})
-	g.Expect(mgr.GetCache().WaitForCacheSync(stopCh)).To(gomega.BeTrue())
-	defer func() {
-		close(stopCh)
-	}()
-
 	defer func() {
 		close(stopMgr)
 		mgrStopped.Wait()
@@ -221,12 +215,6 @@ spec:
 
 	stopMgr, mgrStopped := StartTestManager(mgr, g)
 
-	stopCh := make(chan struct{})
-	g.Expect(mgr.GetCache().WaitForCacheSync(stopCh)).To(gomega.BeTrue())
-	defer func() {
-		close(stopCh)
-	}()
-
 	defer func() {
 		close(stopMgr)
 		mgrStopped.Wait()

diff --git a/pkg/controller/v1alpha2/trial/trial_controller_test.go b/pkg/controller/v1alpha2/trial/trial_controller_test.go
@@ -71,12 +71,6 @@ func TestCreateTFJobTrial(t *testing.T) {
 
 	stopMgr, mgrStopped := StartTestManager(mgr, g)
 
-	stopCh := make(chan struct{})
-	g.Expect(mgr.GetCache().WaitForCacheSync(stopCh)).To(gomega.BeTrue())
-	defer func() {
-		close(stopCh)
-	}()
-
 	defer func() {
 		close(stopMgr)
 		mgrStopped.Wait()
@@ -132,12 +126,6 @@ func TestReconcileTFJobTrial(t *testing.T) {
 
 	stopMgr, mgrStopped := StartTestManager(mgr, g)
 
-	stopCh := make(chan struct{})
-	g.Expect(mgr.GetCache().WaitForCacheSync(stopCh)).To(gomega.BeTrue())
-	defer func() {
-		close(stopCh)
-	}()
-
 	defer func() {
 		close(stopMgr)
 		mgrStopped.Wait()
@@ -211,12 +199,6 @@ func TestReconcileCompletedTFJobTrial(t *testing.T) {
 
 	stopMgr, mgrStopped := StartTestManager(mgr, g)
 
-	stopCh := make(chan struct{})
-	g.Expect(mgr.GetCache().WaitForCacheSync(stopCh)).To(gomega.BeTrue())
-	defer func() {
-		close(stopCh)
-	}()
-
 	defer func() {
 		close(stopMgr)
 		mgrStopped.Wait()
@@ -279,12 +261,6 @@ func TestFailedToCreateTrialInDB(t *testing.T) {
 
 	stopMgr, mgrStopped := StartTestManager(mgr, g)
 
-	stopCh := make(chan struct{})
-	g.Expect(mgr.GetCache().WaitForCacheSync(stopCh)).To(gomega.BeTrue())
-	defer func() {
-		close(stopCh)
-	}()
-
 	defer func() {
 		close(stopMgr)
 		mgrStopped.Wait()