try to fix

kubeflow · Apr 17, 2020 · c5faa93 · c5faa93
1 parent f737625
commit c5faa93
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/pkg/apis/controller/experiments/v1alpha3/constants.go b/pkg/apis/controller/experiments/v1alpha3/constants.go
@@ -26,5 +26,5 @@ const (
 	DefaultTrialTemplatePath = "defaultTrialTemplate.yaml"
 
 	// Default value of Spec.DefaultResumePolicy
-	DefaultResumePolicy = NeverResume
+	DefaultResumePolicy = LongRunning
 )
diff --git a/pkg/controller.v1alpha3/suggestion/suggestion_controller.go b/pkg/controller.v1alpha3/suggestion/suggestion_controller.go
@@ -135,7 +135,7 @@ func (r *ReconcileSuggestion) Reconcile(request reconcile.Request) (reconcile.Re
 	}
 	instance := oldS.DeepCopy()
 	// If ResumePolicyType is LongRunning, suggestion status will never be succeeded.
-	if instance.IsCompleted() {
+	if instance.IsSucceeded() {
 		err = r.deleteDeployment(instance)
 		if err != nil {
 			return reconcile.Result{}, err