review: turn off leader-election by default

cmd/katib-controller/v1beta1/main.go

@@ -59,7 +59,7 @@ func main() {
 	flag.Var(&trialResources, "trial-resources", "The list of resources that can be used as trial template, in the form: Kind.version.group (e.g. TFJob.v1.kubeflow.org)")
 	flag.IntVar(&webhookPort, "webhook-port", 8443, "The port number to be used for admission webhook server.")
 	// For leader election
-	flag.BoolVar(&enableLeaderElection, "enable-leader-election", true, "Enable leader election for katib-controller. Enabling this will ensure there is only one active katib-controller.")
+	flag.BoolVar(&enableLeaderElection, "enable-leader-election", false, "Enable leader election for katib-controller. Enabling this will ensure there is only one active katib-controller.")
 	flag.StringVar(&leaderElectionID, "leader-election-id", "3fbc96e9.katib.kubeflow.org", "The ID for leader election.")
 
 	// TODO (andreyvelich): Currently it is not possible to set different webhook service name.

docs/developer-guide.md

@@ -64,7 +64,7 @@ Below is a list of command-line flags accepted by Katib controller:
 | trial-resources                 | []schema.GroupVersionKind | null                          | The list of resources that can be used as trial template, in the form: Kind.version.group (e.g. TFJob.v1.kubeflow.org) |
 | webhook-inject-securitycontext  | bool                      | false                         | Inject the securityContext of container[0] in the sidecar                                                              |
 | webhook-port                    | int                       | 8443                          | The port number to be used for admission webhook server                                                                |
-| enable-leader-election          | bool                      | true                          | Enable leader election for katib-controller. Enabling this will ensure there is only one active katib-controller.      |
+| enable-leader-election          | bool                      | false                         | Enable leader election for katib-controller. Enabling this will ensure there is only one active katib-controller.      |
 | leader-election-id              | string                    | "3fbc96e9.katib.kubeflow.org" | The ID for leader election.                                                                                            |
 
 ## Workflow design

manifests/v1beta1/installs/katib-leader-election/kustomization.yaml

@@ -0,0 +1,17 @@
+apiVersion: kustomize.config.k8s.io/v1beta1
+kind: Kustomization
+namespace: kubeflow
+resources:
+  - ../katib-standalone
+  # rbac for leader-election
+  - leader-election-rbac.yaml
+replicas:
+  - name: katib-controller
+    count: 2
+patchesJson6902:
+  - target:
+      group: apps
+      version: v1
+      kind: Deployment
+      name: katib-controller
+    path: ./patches/controller.yaml

manifests/v1beta1/installs/katib-leader-election/patches/controller.yaml

@@ -0,0 +1,3 @@
+- op: add
+  path: /spec/template/spec/containers/0/args/-
+  value: "--enable-leader-election"

scripts/v1beta1/deploy.sh

@@ -19,4 +19,4 @@ set -o xtrace
 SCRIPT_ROOT=$(dirname ${BASH_SOURCE})/../..
 
 cd ${SCRIPT_ROOT}
-kustomize build manifests/v1beta1/installs/ha/katib-standalone | kubectl apply -f -
+kustomize build manifests/v1beta1/installs/katib-standalone | kubectl apply -f -

scripts/v1beta1/undeploy.sh

@@ -23,4 +23,4 @@ sleep 10
 SCRIPT_ROOT=$(dirname ${BASH_SOURCE})/../..
 
 cd ${SCRIPT_ROOT}
-kustomize build manifests/v1beta1/installs/ha/katib-standalone | kubectl delete -f -
+kustomize build manifests/v1beta1/installs/katib-standalone | kubectl delete -f -