Fixed precommit lint check and directory bug in tune e2e tests

Signed-off-by: Prakhar Singhal <singhalprakhar479@gmail.com>
kubeflow · Sep 2, 2024 · 3f4ea55 · 3f4ea55
1 parent 2222b99
commit 3f4ea55
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 6 deletions.
diff --git a/test/e2e/v1beta1/scripts/gh-actions/Dockerfile.dummy-collector b/test/e2e/v1beta1/scripts/gh-actions/Dockerfile.dummy-collector
@@ -2,8 +2,8 @@ FROM python:3.8-slim
 
 WORKDIR /app
 
-COPY dummy-collector.py .
+COPY test/e2e/v1beta1/scripts/gh-actions/dummy-collector.py .
 
 RUN pip install kubernetes
 
-CMD ["python", "dummy-collector.py"]
+CMD ["python", "dummy-collector.py"]
diff --git a/test/e2e/v1beta1/scripts/gh-actions/build-load.sh b/test/e2e/v1beta1/scripts/gh-actions/build-load.sh
diff --git a/test/e2e/v1beta1/scripts/gh-actions/dummy-collector.py b/test/e2e/v1beta1/scripts/gh-actions/dummy-collector.py
@@ -2,8 +2,7 @@
 import logging
 import time
 
-from kubernetes import client
-from kubernetes import config
+from kubernetes import client, config
 
 # The default logging config.
 logging.basicConfig(level=logging.INFO)

diff --git a/test/e2e/v1beta1/scripts/gh-actions/run-e2e-tune-api.py b/test/e2e/v1beta1/scripts/gh-actions/run-e2e-tune-api.py
@@ -59,7 +59,7 @@ def objective(parameters):
         resources_per_trial={"cpu": "2"},
         metrics_collector_config={
             "kind": "Custom",
-            "customCollector": metric_collector,
+            "custom_collector": metric_collector,
         },
     )
     experiment = katib_client.wait_for_experiment_condition(
@@ -118,7 +118,6 @@ def objective(parameters):
     logging.debug(katib_client.get_experiment(exp_name, exp_namespace))
     logging.debug(katib_client.get_suggestion(exp_name, exp_namespace))
 
-
 if __name__ == "__main__":
     parser = argparse.ArgumentParser()
     parser.add_argument(