Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hbelmiro as member to kubeflow org #655

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

hbelmiro
Copy link
Contributor

Resolve: #654

Contributions

pytest output:

github-orgs git:(add-hbelmiro) pytest test_org_yaml.py
============================================================================================================ test session starts ============================================================================================================
platform linux -- Python 3.12.1, pytest-7.3.2, pluggy-1.2.0
rootdir: /home/hbelmiro/dev/kubeflow/kubeflow-internal-acls/github-orgs
collected 1 item                                                                                                                                                                                                                            

test_org_yaml.py .                                                                                                                                                                                                                    [100%]

============================================================================================================= 1 passed in 0.17s =============================================================================================================

Signed-off-by: hbelmiro <helber.belmiro@gmail.com>
Copy link

Hi @hbelmiro. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rimolive
Copy link
Member

/lgtm

Helber has been a good contributor not only for pipelines but for Kubeflow release as well. He volunteered to work as Docs lead.

@rimolive
Copy link
Member

/assign @terrytangyuan

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hbelmiro, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 437a7d2 into kubeflow:master Feb 22, 2024
4 checks passed
@hbelmiro hbelmiro deleted the add-hbelmiro branch February 22, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add hbelmiro as member to kubeflow org
3 participants